]> git.ipfire.org Git - thirdparty/util-linux.git/commit
write: fix setuid related regression
authorWayne Pollock <profwaynepollock@gmail.com>
Wed, 4 May 2016 16:15:14 +0000 (17:15 +0100)
committerSami Kerola <kerolasa@iki.fi>
Sat, 7 May 2016 21:49:41 +0000 (22:49 +0100)
commit3e90d04af98c476f024ec12e5296b88d6dd830bf
tree7793e0a7154f4de494714fc7f8d061cbd52e086a
parentf0b3b904c7972374e8b9a280164508e356e9b5be
write: fix setuid related regression

The write(1) is commonly a setuid binary, because common users cannot by
default write to each others terminals.  Since the commit in reference, that
is part of releases v2.24 to v2.28, the write(1) has used access(2) to check
capability to write to a destination terminal.  The catch is that access(2)
uses real UID and GID to when performing the accessibility.  The obvious
correction is to avoid access(2) when in context of setuid binaries.

As a smaller fix, but equally important fix, ensure the 'msgsok' variable is
initialized to indicate no access.  Uninitialized variable will almost
certainly do wrong thing at the time of check.

Breaking-commit: 0233a8ea18bec17dd59cfe1fec8281
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Wayne Pollock <profwaynepollock@gmail.com>
term-utils/write.c