]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Check for fseeko() failure in pg_dump's _tarAddFile().
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 9 Aug 2020 16:39:08 +0000 (12:39 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 9 Aug 2020 16:39:08 +0000 (12:39 -0400)
commit3ed76bd3592f9d476edc0616b527c6fdce71ce85
tree486d0db7da8e478e4e2af6b240e525c627a2b549
parent29cfa88b942bf1febce157b8d7fe59cf421a1515
Check for fseeko() failure in pg_dump's _tarAddFile().

Coverity pointed out, not unreasonably, that we checked fseeko's
result at every other call site but these.  Failure to seek in the
temp file (note this is NOT pg_dump's output file) seems quite
unlikely, and even if it did happen the file length cross-check
further down would probably detect the problem.  Still, that's a
poor excuse for not checking the result of a system call.
src/bin/pg_dump/pg_backup_tar.c