]> git.ipfire.org Git - thirdparty/asterisk.git/commit
AST-2017-012: Place single RTCP report block at beginning of report.
authorJoshua Colp <jcolp@digium.com>
Thu, 30 Nov 2017 16:12:55 +0000 (16:12 +0000)
committerJoshua Colp <jcolp@digium.com>
Wed, 13 Dec 2017 13:12:14 +0000 (07:12 -0600)
commit3eea735a3948551b547bbfe964dcb49216e17e14
tree9af3e1e341f2d46119bb68f5f4714a91ac7b7111
parent7c0bc7297295291b09fa4396c6ee2bca80cddecb
AST-2017-012: Place single RTCP report block at beginning of report.

When the RTCP code was transitioned over to Stasis a code change
was made to keep track of how many reports are present. This count
controlled where report blocks were placed in the RTCP report.

If a compound RTCP packet was received this logic would incorrectly
place a report block in the wrong location resulting in a write
to an invalid location.

This change removes this counting logic and always places the report
block at the first position. If in the future multiple reports are
supported the logic can be extended but for now keeping a count
serves no purpose.

ASTERISK-27382
ASTERISK-27429

Change-Id: Iad6c8a9985c4b608ef493e19c421211615485116
res/res_rtp_asterisk.c