]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
vsock/virtio: fix potential underflow in virtio_transport_get_credit()
authorMelbin K Mathew <mlbnkm1@gmail.com>
Wed, 21 Jan 2026 09:36:25 +0000 (10:36 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 22 Jan 2026 14:41:33 +0000 (15:41 +0100)
commit3ef3d52a1a9860d094395c7a3e593f3aa26ff012
tree9f7e77c2709e0a74fe926fc910588e53ec12b06d
parentca1bb3fedf26a08ed31974131bc0064d4fe33649
vsock/virtio: fix potential underflow in virtio_transport_get_credit()

The credit calculation in virtio_transport_get_credit() uses unsigned
arithmetic:

  ret = vvs->peer_buf_alloc - (vvs->tx_cnt - vvs->peer_fwd_cnt);

If the peer shrinks its advertised buffer (peer_buf_alloc) while bytes
are in flight, the subtraction can underflow and produce a large
positive value, potentially allowing more data to be queued than the
peer can handle.

Reuse virtio_transport_has_space() which already handles this case and
add a comment to make it clear why we are doing that.

Fixes: 06a8fc78367d ("VSOCK: Introduce virtio_vsock_common.ko")
Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Melbin K Mathew <mlbnkm1@gmail.com>
[Stefano: use virtio_transport_has_space() instead of duplicating the code]
[Stefano: tweak the commit message]
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Luigi Leonardi <leonardi@redhat.com>
Link: https://patch.msgid.link/20260121093628.9941-2-sgarzare@redhat.com
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/vmw_vsock/virtio_transport_common.c