]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cpuidle: Avoid potential overflow in integer multiplication
authorC Cheng <C.Cheng@mediatek.com>
Tue, 19 Dec 2023 03:14:42 +0000 (11:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Apr 2024 11:07:29 +0000 (13:07 +0200)
commit3f0a74728170a958dcc1c4cf3f47353b35baac78
treeba86052439f1b4f783304449ad3c29d6eda06a3a
parent750d44684a95c1ca0d6c8a7e2d24abb500790ee6
cpuidle: Avoid potential overflow in integer multiplication

[ Upstream commit 88390dd788db485912ee7f9a8d3d56fc5265d52f ]

In detail:

In C language, when you perform a multiplication operation, if
both operands are of int type, the multiplication operation is
performed on the int type, and then the result is converted to
the target type. This means that if the product of int type
multiplication exceeds the range that int type can represent,
an overflow will occur even if you store the result in a
variable of int64_t type.

For a multiplication of two int values, it is better to use
mul_u32_u32() rather than s->exit_latency_ns = s->exit_latency *
NSEC_PER_USEC to avoid potential overflow happenning.

Signed-off-by: C Cheng <C.Cheng@mediatek.com>
Signed-off-by: Bo Ye <bo.ye@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
[ rjw: New subject ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/cpuidle/driver.c