]> git.ipfire.org Git - thirdparty/util-linux.git/commit
tailf: Fix previously adjusted segfault patch
authorTobias Stoeckmann <tobias@stoeckmann.org>
Sat, 16 Jul 2016 10:51:42 +0000 (12:51 +0200)
committerKarel Zak <kzak@redhat.com>
Tue, 19 Jul 2016 09:01:18 +0000 (11:01 +0200)
commit3f0e7f371a398a5b8ef23ff94651de13f4f987d3
treef8a8b7d3099d5d59bf9f4292d5e9044b7ad28231
parentb8fd5c055889edcefdd97afa2abb35b71e6fa369
tailf: Fix previously adjusted segfault patch

Casting the value to be checked to size_t renders the check useless.
If st_size is SIZE_MAX+1, it will be truncated to 0 and the check
succeeds. In fact, this check can never be false because every value
stored in a size_t is smaller or equal to SIZE_MAX.

I think this adjustment was meant to fix a compiler warning for 64 bit
systems for which sizeof(off_t) is sizeof(size_t), but the signedness
differs.

Going unconditionally to the greatest possible unsigned int type if
st_size is positive (off_t is signed) will fix this issue.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
text-utils/tailf.c