]> git.ipfire.org Git - thirdparty/libvirt.git/commit
conf: Always format storage source auth and encryption under <source> for backing...
authorPeter Krempa <pkrempa@redhat.com>
Fri, 10 Jan 2020 16:25:16 +0000 (17:25 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 13 Jan 2020 11:53:58 +0000 (12:53 +0100)
commit3f2d167d9c733f588e693d44d7aa9b21dcb415c7
treedbb5807ec94c8ad5450c95261b80a7f2b7f51a28
parent23b52d94204e0d070c4435df2db3953e9c3ded6c
conf: Always format storage source auth and encryption under <source> for backing files

Historically there are two places where we format authentication and
encryption for a disk. The logich which formats it for backing files was
flawed though and didn't format it at all. This worked if the image
became a backing file through the means of a snapshot but not directly.

Force formatting of the source and encryption for any non-disk case to
fix the issue.

This caused problems in many places as we use the formatter to copy the
definition. Effectively any copy lost the secret definition.

https://bugzilla.redhat.com/show_bug.cgi?id=1789310
https://bugzilla.redhat.com/show_bug.cgi?id=1788898

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
src/conf/backup_conf.c
src/conf/domain_conf.c
src/conf/domain_conf.h
src/conf/snapshot_conf.c
src/qemu/qemu_domain.c
tests/qemublocktest.c
tests/qemuxml2xmloutdata/luks-disks-source-qcow2.x86_64-latest.xml
tests/virstoragetest.c