]> git.ipfire.org Git - thirdparty/linux.git/commit
watchdog: starfive-wdt: Fix PM reference leak in probe error path
authorKery Qi <qikeyu2017@gmail.com>
Sun, 11 Jan 2026 17:29:15 +0000 (01:29 +0800)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sat, 17 Jan 2026 12:09:12 +0000 (13:09 +0100)
commit3f2d8d79cceb05a8b8dd200fa81c0dffc59ec46f
treef88d5c2b360c8c034d42e4c266d0d0edc2761c3c
parent88b2ab346436f799b99894a3e9518a3ffa344524
watchdog: starfive-wdt: Fix PM reference leak in probe error path

The PM reference count is not expected to be incremented on return in
functions starfive_wdt_probe.

However, pm_runtime_get_sync will increment pm usage counter
even failed. Forgetting to putting operation will result in a
reference leak here.

Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.

Fixes: db728ea9c7be ("drivers: watchdog: Add StarFive Watchdog driver")
Signed-off-by: Kery Qi <qikeyu2017@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/starfive-wdt.c