]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
batman-adv: Drop immediate orig_node free function
authorSven Eckelmann <sven@narfation.org>
Tue, 5 Jan 2016 11:06:20 +0000 (12:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 31 Jan 2016 19:25:52 +0000 (11:25 -0800)
commit3f3f7cabcdecfbd3dca31d67c33b4704fe37b094
treeeb376715f28b74b31fc8fe4fc9252868d1aaadec
parent7c2b5cfe9e7cb4dbad762e4a4824291dbb779dd2
batman-adv: Drop immediate orig_node free function

[ Upstream commit 42eff6a617e23b691f8e4467f4687ed7245a92db ]

It is not allowed to free the memory of an object which is part of a list
which is protected by rcu-read-side-critical sections without making sure
that no other context is accessing the object anymore. This usually happens
by removing the references to this object and then waiting until the rcu
grace period is over and no one (allowedly) accesses it anymore.

But the _now functions ignore this completely. They free the object
directly even when a different context still tries to access it. This has
to be avoided and thus these functions must be removed and all functions
have to use batadv_orig_node_free_ref.

Fixes: 72822225bd41 ("batman-adv: Fix rcu_barrier() miss due to double call_rcu() in TT code")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/batman-adv/originator.c
net/batman-adv/originator.h
net/batman-adv/translation-table.c