]> git.ipfire.org Git - thirdparty/linux.git/commit
isdn: mISDN: hfcsusb: fix memory leak in hfcsusb_probe()
authorAbdun Nihaal <nihaal@cse.iitm.ac.in>
Thu, 30 Oct 2025 04:25:22 +0000 (09:55 +0530)
committerJakub Kicinski <kuba@kernel.org>
Sat, 1 Nov 2025 00:39:14 +0000 (17:39 -0700)
commit3f978e3f1570155a1327ffa25f60968bc7b9398f
tree3a520e8a46f77566a337efcbfcf8986cd2d38016
parentf8e8486702abb05b8c734093aab1606af0eac068
isdn: mISDN: hfcsusb: fix memory leak in hfcsusb_probe()

In hfcsusb_probe(), the memory allocated for ctrl_urb gets leaked when
setup_instance() fails with an error code. Fix that by freeing the urb
before freeing the hw structure. Also change the error paths to use the
goto ladder style.

Compile tested only. Issue found using a prototype static analysis tool.

Fixes: 69f52adb2d53 ("mISDN: Add HFC USB driver")
Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Link: https://patch.msgid.link/20251030042524.194812-1-nihaal@cse.iitm.ac.in
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/isdn/hardware/mISDN/hfcsusb.c