]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mmc: host: Return an error when ->enable_sdio_irq() ops is missing
authorUlf Hansson <ulf.hansson@linaro.org>
Thu, 3 Mar 2022 16:51:42 +0000 (17:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:08:23 +0000 (09:08 +0200)
commit3fac2cb56ba5205547e296b193e52871f9dc3845
tree9c15b3ea67c70dc0c4c74fd1c65267d4a530ee39
parentdd551d0ab0eec9a7334ea7a5ecb3e48a5d03f6c5
mmc: host: Return an error when ->enable_sdio_irq() ops is missing

[ Upstream commit d6c9219ca1139b74541b2a98cee47a3426d754a9 ]

Even if the current WARN() notifies the user that something is severely
wrong, we can still end up in a PANIC() when trying to invoke the missing
->enable_sdio_irq() ops. Therefore, let's also return an error code and
prevent the host from being added.

While at it, move the code into a separate function to prepare for
subsequent changes and for further host caps validations.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Link: https://lore.kernel.org/r/20220303165142.129745-1-ulf.hansson@linaro.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/core/host.c