]> git.ipfire.org Git - thirdparty/ipxe.git/commit
[efi] Fix Coverity warning about unintended sign extension
authorMichael Brown <mcb30@ipxe.org>
Tue, 19 Dec 2023 16:56:34 +0000 (16:56 +0000)
committerMichael Brown <mcb30@ipxe.org>
Tue, 19 Dec 2023 16:56:34 +0000 (16:56 +0000)
commit3fc1b407d204e950a41c567e84f4c4f079cc052e
treea8397c3dcb94c2b16dd9221ead430c1302e52eb7
parent0958e01463f7ad6a532939e77712ed31b4a12dbc
[efi] Fix Coverity warning about unintended sign extension

The result of multiplying a uint16_t by another uint16_t will be a
signed int.  Comparing this against a size_t will perform an unwanted
sign extension.

Fix by explicitly casting e_phnum to an unsigned int, thereby matching
the data type used for the loop index variable (and avoiding the
unwanted sign extension).

This mirrors wimboot commit 15f6162 ("[efi] Fix Coverity warning about
unintended sign extension").

Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/util/elf2efi.c