]> git.ipfire.org Git - thirdparty/git.git/commit
revision: clarify a 'return NULL' in get_reference()
authorChristian Couder <christian.couder@gmail.com>
Wed, 14 Feb 2024 14:25:10 +0000 (15:25 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 14 Feb 2024 17:38:22 +0000 (09:38 -0800)
commit3ff56af99b1c9becd9e603b59986359f553e62a8
tree08b10d2d735bfa9b65f48ee2d540b3cec3b172b9
parent75389e275c288a328272b70e841ada767313a739
revision: clarify a 'return NULL' in get_reference()

When we know a pointer variable is NULL, it's clearer to
explicitly return NULL than to return that variable.

In get_reference(), when 'object' is NULL, we already return NULL
when 'revs->exclude_promisor_objects && is_promisor_object(oid)' is
true, but we return 'object' when 'revs->ignore_missing' is true.

Let's make the code clearer and more uniform by also explicitly
returning NULL when 'revs->ignore_missing' is true.

Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
revision.c