]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
selinux: fix residual uses of current_security() for the SELinux blob
authorStephen Smalley <sds@tycho.nsa.gov>
Wed, 4 Sep 2019 14:32:48 +0000 (10:32 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2019 16:59:31 +0000 (18:59 +0200)
commit400a250cc06f40548042561ce166505aff2fce11
tree4ef62f66f6abbba87213c4da28edab9210ae38df
parent30f8969d6265891d30ef0b2ee236020932e3b20d
selinux: fix residual uses of current_security() for the SELinux blob

[ Upstream commit 169ce0c081cd85f78388bb6c1638c1ad7b81bde7 ]

We need to use selinux_cred() to fetch the SELinux cred blob instead
of directly using current->security or current_security().  There
were a couple of lingering uses of current_security() in the SELinux code
that were apparently missed during the earlier conversions. IIUC, this
would only manifest as a bug if multiple security modules including
SELinux are enabled and SELinux is not first in the lsm order. After
this change, there appear to be no other users of current_security()
in-tree; perhaps we should remove it altogether.

Fixes: bbd3662a8348 ("Infrastructure management of the cred security blob")
Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
Acked-by: Casey Schaufler <casey@schaufler-ca.com>
Reviewed-by: James Morris <jamorris@linux.microsoft.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
security/selinux/hooks.c
security/selinux/include/objsec.h