]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
smb: client: validate change notify buffer before copy
authorJoshua Rogers <linux@joshua.hu>
Thu, 6 Nov 2025 16:09:37 +0000 (00:09 +0800)
committerSteve French <stfrench@microsoft.com>
Fri, 7 Nov 2025 16:15:43 +0000 (10:15 -0600)
commit4012abe8a78fbb8869634130024266eaef7081fe
tree45dd4c2e376debf671f20d08041b2476b9338192
parentb540de9e3b4fab3b9e10f30714a6f5c1b2a50ec3
smb: client: validate change notify buffer before copy

SMB2_change_notify called smb2_validate_iov() but ignored the return
code, then kmemdup()ed using server provided OutputBufferOffset/Length.

Check the return of smb2_validate_iov() and bail out on error.

Discovered with help from the ZeroPath security tooling.

Signed-off-by: Joshua Rogers <linux@joshua.hu>
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
Cc: stable@vger.kernel.org
Fixes: e3e9463414f61 ("smb3: improve SMB3 change notification support")
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2pdu.c