]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
projects / thirdparty / Python / cpython.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9dacf43) | patch
gh-121459: Add missing return to _PyDict_LoadGlobalStackRef (#124085)
authorSam Gross <colesbury@gmail.com>
Sat, 14 Sep 2024 18:29:55 +0000 (14:29 -0400)
committerGitHub <noreply@github.com>
Sat, 14 Sep 2024 18:29:55 +0000 (14:29 -0400)
commit401fff7423ca3c8bf1d02e594edfd1412616a559
treeb2f460a0735c2b01284027c1decc567916bc856ctree | snapshot
parent9dacf430c2f4af2acd870291a649b7b957efcd2ccommit | diff
gh-121459: Add missing return to _PyDict_LoadGlobalStackRef (#124085)

We need to return immediately if there's an error during dictionary
lookup.

Also avoid the conditional-if operator. MSVC versions through v19.27 miscompile
compound literals with side effects within a conditional operator. This caused
crashes in the Windows10 buildbot.
Objects/dictobject.c diff | blob | blame | history
Mirror of https://github.com/python/cpython.git