]> git.ipfire.org Git - thirdparty/asterisk.git/commit
AST-2013-004: Fix crash when handling ACK on dialog that has no channel
authorMatthew Jordan <mjordan@digium.com>
Tue, 27 Aug 2013 17:37:23 +0000 (17:37 +0000)
committerMatthew Jordan <mjordan@digium.com>
Tue, 27 Aug 2013 17:37:23 +0000 (17:37 +0000)
commit40404bccb200fea3a8c04ec59ccaae4dd13ae33b
treeae987bfbc85da7c02e1b7591d68f2a1e49106fc5
parentbf3fa65f6d95d6de95429a4a6a88f03fae46e68d
AST-2013-004: Fix crash when handling ACK on dialog that has no channel

A remote exploitable crash vulnerability exists in the SIP channel driver if an
ACK with SDP is received after the channel has been terminated. The handling
code incorrectly assumed that the channel would always be present.

This patch adds a check such that the SDP will only be parsed and applied if
Asterisk has a channel present that is associated with the dialog.

Note that the patch being applied was modified only slightly from the patch
provided by Walter Doekes of OSSO B.V.

(closes issue ASTERISK-21064)
Reported by: Colin Cuthbertson
Tested by: wdoekes, Colin Cutherbertson
patches:
  issueA21064_fix.patch uploaded by wdoekes (License 5674)
........

Merged revisions 397710 from http://svn.asterisk.org/svn/asterisk/branches/1.8

git-svn-id: https://origsvn.digium.com/svn/asterisk/certified/branches/1.8.15@397754 65c4cc65-6c06-0410-ace0-fbb531ad65f3
channels/chan_sip.c