]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
block: fix alignment_offset math that assumes io_min is a power-of-2
authorMike Snitzer <snitzer@redhat.com>
Wed, 8 Oct 2014 22:26:13 +0000 (18:26 -0400)
committerJiri Slaby <jslaby@suse.cz>
Thu, 13 Nov 2014 18:02:21 +0000 (19:02 +0100)
commit40e8412c09dbb9a60aaba93a91c4d56e88caa9c8
treea4d221cf50c72dafb3b1adea119b3019173b6b26
parent5fa353fffaae9794ac109d748e2c6a9808abbba0
block: fix alignment_offset math that assumes io_min is a power-of-2

commit b8839b8c55f3fdd60dc36abcda7e0266aff7985c upstream.

The math in both blk_stack_limits() and queue_limit_alignment_offset()
assume that a block device's io_min (aka minimum_io_size) is always a
power-of-2.  Fix the math such that it works for non-power-of-2 io_min.

This issue (of alignment_offset != 0) became apparent when testing
dm-thinp with a thinp blocksize that matches a RAID6 stripesize of
1280K.  Commit fdfb4c8c1 ("dm thin: set minimum_io_size to pool's data
block size") unlocked the potential for alignment_offset != 0 due to
the dm-thin-pool's io_min possibly being a non-power-of-2.

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
block/blk-settings.c
include/linux/blkdev.h