]> git.ipfire.org Git - thirdparty/linux.git/commit
spi: nxp-xspi: Use reinit_completion() for repeated operations
authorFelix Gu <ustc.gu@gmail.com>
Wed, 4 Mar 2026 12:47:19 +0000 (20:47 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 9 Mar 2026 20:12:04 +0000 (20:12 +0000)
commit40f9bc646db5aa89fb85f2cda1e55a2bf9d6a30c
tree64bb0c2e6245cd13959dc459d93325799439d287
parent96f06d055ca03d1dfb5830fd07ff6eadbd66264c
spi: nxp-xspi: Use reinit_completion() for repeated operations

The driver currently calls init_completion() during every spi_mem_op.
Tchnically it may work, but it's not the recommended pattern.

According to the kernel documentation: Calling init_completion() on
the same completion object twice is most likely a bug as it
re-initializes the queue to an empty queue and enqueued tasks
could get "lost" - use reinit_completion() in that case, but be
aware of other races.

So moves the initial initialization to probe function and uses
reinit_completion() for subsequent operations.

Fixes: 29c8c00d9f9d ("spi: add driver for NXP XSPI controller")
Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260304-spi-nxp-v2-1-cd7d7726a27e@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-nxp-xspi.c