]> git.ipfire.org Git - thirdparty/linux.git/commit
ethtool: Don't check for RXFH fields conflict when no input_xfrm is requested
authorGal Pressman <gal@nvidia.com>
Tue, 15 Jul 2025 14:07:54 +0000 (17:07 +0300)
committerJakub Kicinski <kuba@kernel.org>
Wed, 16 Jul 2025 22:03:56 +0000 (15:03 -0700)
commit410b0ace8891a324d31efdc445b07b0e3054a68c
tree50fcf3d4921a9da0fa6a038cef668f78734a47aa
parent3047957cc7c19433dc8b88a7fec471efa13ba034
ethtool: Don't check for RXFH fields conflict when no input_xfrm is requested

The requirement of ->get_rxfh_fields() in ethtool_set_rxfh() is there to
verify that we have no conflict of input_xfrm with the RSS fields
options, there is no point in doing it if input_xfrm is not
supported/requested.

This is under the assumption that a driver that supports input_xfrm will
also support ->get_rxfh_fields(), so add a WARN_ON() to
ethtool_check_ops() to verify it, and remove the op NULL check.

This fixes the following error in mlx4_en, which doesn't support
getting/setting RXFH fields.
$ ethtool --set-rxfh-indir eth2 hfunc xor
Cannot set RX flow hash configuration: Operation not supported

Fixes: 72792461c8e8 ("net: ethtool: don't mux RXFH via rxnfc callbacks")
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Link: https://patch.msgid.link/20250715140754.489677-1-gal@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/common.c
net/ethtool/ioctl.c