]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sfc: falcon: refactor and document ef4_ethtool_get_rxfh_fields
authorEdward Cree <ecree.xilinx@gmail.com>
Thu, 10 Jul 2025 17:32:13 +0000 (18:32 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 11 Jul 2025 23:43:16 +0000 (16:43 -0700)
commit4159a55f29e153e3d1d9f78f9476a022368f26b0
tree2c5d0ecd80110e60638c98f99ca4422a5d27e005
parentf45b45cbfae394583394051444f766fff3c151f5
sfc: falcon: refactor and document ef4_ethtool_get_rxfh_fields

The code had some rather odd control flow inherited from when it was
 shared with siena and ef10 before this driver was split out.
Simplify that for easier reading.
Also add a comment explaining why we return the values we do, since
 some Falcon documents and datasheets confusingly mention the part
 supporting 4-tuple UDP hashing.
(I couldn't find any record of exactly what was "broken" about the
 original Falcon A hash, I'm just trusting that falcon_init_rx_cfg()
 had a good reason for not using it.)

Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Link: https://patch.msgid.link/20250710173213.1638397-1-edward.cree@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/sfc/falcon/ethtool.c