]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
can: j1939: j1939_session_new(): fix skb reference counting
authorDmitry Antipov <dmantipov@yandex.ru>
Tue, 5 Nov 2024 09:48:23 +0000 (12:48 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 18:51:27 +0000 (19:51 +0100)
commit4199dd78a59896e091d3a7a05a77451aa7fd724d
tree9592cb5b2234b32e8d49de82389d725d160cfbb6
parentc6e778901d0055356c4fb223058364cae731494a
can: j1939: j1939_session_new(): fix skb reference counting

[ Upstream commit a8c695005bfe6569acd73d777ca298ddddd66105 ]

Since j1939_session_skb_queue() does an extra skb_get() for each new
skb, do the same for the initial one in j1939_session_new() to avoid
refcount underflow.

Reported-by: syzbot+d4e8dc385d9258220c31@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=d4e8dc385d9258220c31
Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://patch.msgid.link/20241105094823.2403806-1-dmantipov@yandex.ru
[mkl: clean up commit message]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/can/j1939/transport.c