]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
aacraid: prevent invalid pointer dereference
authorMahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>
Thu, 31 Oct 2013 08:31:02 +0000 (14:01 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 29 Nov 2013 18:42:14 +0000 (10:42 -0800)
commit41bbbaa63c176d2c2ee6756a787a168d7f6359bf
tree615fcc8548225efd54dd57eb7f4df960738e6117
parent84640fca73de9c3fac9059c059d33f510084ea95
aacraid: prevent invalid pointer dereference

commit b4789b8e6be3151a955ade74872822f30e8cd914 upstream.

It appears that driver runs into a problem here if fibsize is too small
because we allocate user_srbcmd with fibsize size only but later we
access it until user_srbcmd->sg.count to copy it over to srbcmd.

It is not correct to test (fibsize < sizeof(*user_srbcmd)) because this
structure already includes one sg element and this is not needed for
commands without data.  So, we would recommend to add the following
(instead of test for fibsize == 0).

Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>
Reported-by: Nico Golde <nico@ngolde.de>
Reported-by: Fabian Yamaguchi <fabs@goesec.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/aacraid/commctrl.c