]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: hso: fix NULL-deref on disconnect regression
authorJohan Hovold <johan@kernel.org>
Mon, 26 Apr 2021 08:11:49 +0000 (10:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 2 May 2021 09:10:27 +0000 (11:10 +0200)
commit41c44e1f3112d7265dae522c026399b2a42d19ef
treeef9dfe5631c29313c0b7aa89b3bc733241dc6f99
parent9f4ad9e425a1d3b6a34617b8ea226d56a119a717
net: hso: fix NULL-deref on disconnect regression

commit 2ad5692db72874f02b9ad551d26345437ea4f7f3 upstream.

Commit 8a12f8836145 ("net: hso: fix null-ptr-deref during tty device
unregistration") fixed the racy minor allocation reported by syzbot, but
introduced an unconditional NULL-pointer dereference on every disconnect
instead.

Specifically, the serial device table must no longer be accessed after
the minor has been released by hso_serial_tty_unregister().

Fixes: 8a12f8836145 ("net: hso: fix null-ptr-deref during tty device unregistration")
Cc: stable@vger.kernel.org
Cc: Anirudh Rayabharam <mail@anirudhrb.com>
Reported-by: Leonardo Antoniazzi <leoanto@aruba.it>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Anirudh Rayabharam <mail@anirudhrb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/usb/hso.c