]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
gpu: nova-core: fw: move appropriate code into pin initializer
authorDanilo Krummrich <dakr@kernel.org>
Thu, 18 Dec 2025 15:50:49 +0000 (16:50 +0100)
committerDanilo Krummrich <dakr@kernel.org>
Mon, 29 Dec 2025 16:54:31 +0000 (17:54 +0100)
commit423706aa1c469bfcc3c27a9e8c464f6b88921db7
tree8c934ae83ae6d808b587a7dd24b36dac2ce66b7e
parentdb22fbc15a9cea7e3f74a53d36c381503b6ca43e
gpu: nova-core: fw: move appropriate code into pin initializer

Relocate the code that technically fits in the pin initializer into the
initializer itself.

While, thanks to pin_init_scope(), it is also possible to keep it as is,
moving appropriate code into the initializer has the advantage that it
structures the dependencies of fields naturally.

For instance, intermediate data that is only needed for a single field
goes into the initializer block of this field, making it obvious that it
is not needed by anything else.

On the other hand, intermediate data that is needed for multiple fields
to initialize remains above the initializer, naturally indicating that
it is needed my multiple fields.

Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>
Link: https://patch.msgid.link/20251218155239.25243-3-dakr@kernel.org
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/gpu/nova-core/firmware/gsp.rs