]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
media: uvcvideo: Fix support for V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX
authorRicardo Ribalda <ribalda@chromium.org>
Wed, 19 Nov 2025 20:17:36 +0000 (20:17 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Mon, 5 Jan 2026 11:21:21 +0000 (12:21 +0100)
commit4238bd6dc6ba36f44d89a60338223d5a4f708cbf
tree7619abe3f681e7320d20cbb45c5bf774975a3075
parent85883141d3bea47e5bce688cc300800da7b1ea61
media: uvcvideo: Fix support for V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX

The VIDIOC_G_EXT_CTRLS with which V4L2_CTRL_WHICH_(MIN|MAX)_VAL can only
work for controls that have previously announced support for it.

This patch fixes the following v4l2-compliance error:

  info: checking extended control 'User Controls' (0x00980001)
  fail: v4l2-test-controls.cpp(980): ret != EINVAL (got 13)
        test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL

Fixes: 39d2c891c96e ("media: uvcvideo: support V4L2_CTRL_WHICH_MIN/MAX_VAL")
Cc: stable@vger.kernel.org
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/usb/uvc/uvc_ctrl.c
drivers/media/usb/uvc/uvc_v4l2.c
drivers/media/usb/uvc/uvcvideo.h