]> git.ipfire.org Git - thirdparty/git.git/commit
unpack-objects: use the bulk-checkin infrastructure
authorNeeraj Singh <neerajsi@microsoft.com>
Tue, 5 Apr 2022 05:20:13 +0000 (22:20 -0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 6 Apr 2022 20:13:26 +0000 (13:13 -0700)
commit425d290ce564ada84a5322545dbbd1866f2a29c4
treef7178f2707631a4b316d557418a258fa1831049f
parent23a3a303ab9bfec2321ac4d1ae9f4df279f3a20c
unpack-objects: use the bulk-checkin infrastructure

The unpack-objects functionality is used by fetch, push, and fast-import
to turn the transfered data into object database entries when there are
fewer objects than the 'unpacklimit' setting.

By enabling an odb-transaction when unpacking objects, we can take advantage
of batched fsyncs.

Here are some performance numbers to justify batch mode for
unpack-objects, collected on a WSL2 Ubuntu VM.

Fsync Mode | Time for 90 objects (ms)
-------------------------------------
       Off | 170
  On,fsync | 760
  On,batch | 230

Note that the default unpackLimit is 100 objects, so there's a 3x
benefit in the worst case. The non-batch mode fsync scales linearly
with the number of objects, so there are significant benefits even with
smaller numbers of objects.

Signed-off-by: Neeraj Singh <neerajsi@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/unpack-objects.c