]> git.ipfire.org Git - thirdparty/freeradius-server.git/commit
use dictionary function to compare two attributes
authorAlan T. DeKok <aland@freeradius.org>
Thu, 31 Jul 2025 17:22:02 +0000 (13:22 -0400)
committerAlan T. DeKok <aland@freeradius.org>
Fri, 1 Aug 2025 11:05:54 +0000 (07:05 -0400)
commit42a21f07849fa02c4120f68b241e5ebb22406b27
tree6380acaf5acfd1b259d7d438e9df26f4312783d3
parent8c44461faecc2563410fe7ee6401b5d04cc0a4a5
use dictionary function to compare two attributes

comparing by only the leaf attr was arguably wrong, as it ignored
any depth or parenting.

we use an fr_dict function to do the comparison.  But that just
compares the pointers, and isn't stable.  Arguably that should
be fixed, too.

The fix depends on whether we want to just sort different attributes,
or whether we want to order them.  If we're just sorting them, then
the current code is OK.
src/lib/util/value.c