]> git.ipfire.org Git - thirdparty/krb5.git/commit
Simplify sendto_kdc.c
authorGreg Hudson <ghudson@mit.edu>
Wed, 9 Apr 2014 17:19:03 +0000 (13:19 -0400)
committerGreg Hudson <ghudson@mit.edu>
Mon, 2 Jun 2014 19:10:12 +0000 (15:10 -0400)
commit42b3c2ed11c1e62c1691f868a6796983f93c3beb
tree52a743fa78f0198d7de8ccc3e0dfad7f6345e519
parentca8207d5ab5482e6d09a52bdb8b139cb5a28a95d
Simplify sendto_kdc.c

* Get rid of the "x" member of conn_state, which used to be a union
  but hasn't been since r14742.
* Define a structure type for the "out" member of conn_state.
* Rename incoming_krb5_message to incoming_message for brevity.
* Make the "pos" member of incoming_message an offset instead of a
  pointer, simplifying several present and future computations.
* Use "in" and "out" aliases to the conn_state in and out members
  where it improves brevity.
* Rename set_conn_state_msg_length to set_transport_message and give
  it a descriptive comment.
* Call set_transport_message from start_connection only, instead of
  once in add_connection and perhaps again in start_connection.  To
  make this possible, pass the original message argument to maybe_send
  and start_connection.
* Use make_data and empty_data helpers where appropriate.
src/lib/krb5/os/sendto_kdc.c