]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: rt1308-sdw: use first_hw_init flag on resume
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mon, 7 Jun 2021 22:22:27 +0000 (17:22 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 15:00:19 +0000 (17:00 +0200)
commit42b4402f664402a22b88e8329050b5560fe75f29
tree24fecceb4275c9a65aff789479e90146a4cf299a
parent03f93aa9ed875e2b32b92916e6fa37e1fead46ad
ASoC: rt1308-sdw: use first_hw_init flag on resume

[ Upstream commit 30e102dab5fad1db71684f8ac5e1ac74e49da06d ]

The intent of the status check on resume was to verify if a SoundWire
peripheral reported ATTACHED before waiting for the initialization to
complete. This is required to avoid timeouts that will happen with
'ghost' devices that are exposed in the platform firmware but are not
populated in hardware.

Unfortunately we used 'hw_init' instead of 'first_hw_init'. Due to
another error, the resume operation never timed out, but the volume
settings were not properly restored.

BugLink: https://github.com/thesofproject/linux/issues/2908
BugLink: https://github.com/thesofproject/linux/issues/2637
Fixes: a87a6653a28c0 ('ASoC: rt1308-sdw: add rt1308 SdW amplifier driver')
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Bard Liao <bard.liao@intel.com>
Link: https://lore.kernel.org/r/20210607222239.582139-4-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/rt1308-sdw.c