]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
virtio-net: set queues after driver_ok
authorJason Wang <jasowang@redhat.com>
Thu, 10 Aug 2023 03:12:56 +0000 (23:12 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 26 Aug 2023 12:23:38 +0000 (14:23 +0200)
commit431db3f48c286462ad7453ccdf284f590aafa949
tree813f1614232aa65e03b7cc93b631e2a6499dd5f5
parentd39fc9b94dc0719afa4bc8e58341a5eb41febef3
virtio-net: set queues after driver_ok

commit 51b813176f098ff61bd2833f627f5319ead098a5 upstream.

Commit 25266128fe16 ("virtio-net: fix race between set queues and
probe") tries to fix the race between set queues and probe by calling
_virtnet_set_queues() before DRIVER_OK is set. This violates virtio
spec. Fixing this by setting queues after virtio_device_ready().

Note that rtnl needs to be held for userspace requests to change the
number of queues. So we are serialized in this way.

Fixes: 25266128fe16 ("virtio-net: fix race between set queues and probe")
Reported-by: Dragos Tatulea <dtatulea@nvidia.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/virtio_net.c