]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-42369: Fix thread safety of zipfile._SharedFile.tell (GH-26974)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Sun, 20 Mar 2022 14:51:11 +0000 (07:51 -0700)
committerGitHub <noreply@github.com>
Sun, 20 Mar 2022 14:51:11 +0000 (07:51 -0700)
commit4352ca234e979ad1c7158981addf899b119cd448
tree5de0c4ac29404d4c35e8303646b1626b0578282f
parent87b3e202d46cdeb0a6b1ef041579a5ebc7c826a9
bpo-42369: Fix thread safety of zipfile._SharedFile.tell (GH-26974)

The `_SharedFile` tracks its own virtual position into the file as
`self._pos` and updates it after reading or seeking. `tell()` should
return this position instead of calling into the underlying file object,
since if multiple `_SharedFile` instances are being used concurrently on
the same file, another one may have moved the real file position.
Additionally, calling into the underlying `tell` may expose thread
safety issues in the underlying file object because it was called
without taking the lock.
(cherry picked from commit e730ae7effe4f13b24f1b5fb1fca005709c86acb)

Co-authored-by: Kevin Mehall <km@kevinmehall.net>
Lib/zipfile.py
Misc/NEWS.d/next/Library/2022-03-19-19-56-04.bpo-42369.Ok828t.rst [new file with mode: 0644]