]> git.ipfire.org Git - thirdparty/samba.git/commit
selftest: Export DC conf path for special cases
authorTim Beale <timbeale@catalyst.net.nz>
Mon, 11 Feb 2019 04:15:22 +0000 (17:15 +1300)
committerKarolin Seeger <kseeger@samba.org>
Wed, 4 Mar 2020 11:26:37 +0000 (11:26 +0000)
commit43b343786e36cc440df993ae78d241f2fbea1ac1
tree545597addca4a85f0a9ddfe7df3cc8d8b4227a6b
parent1905ed84f8a1c05e08a95c104d3a0200d35bd08c
selftest: Export DC conf path for special cases

In a few rare cases, a test needs to assert aspects both client-side and
server-side aspects. A typical example would be the audit logging, which
is exercising client-side behaviour, but also asserting the server-side
logging.

Usually this has involved a kludge in tests.py to either use
socket-wrapper explicitly, or hardcode in the server smb.conf path.

This patch exposes the existing SERVERCONFFILE env variable to the
tests. DC_SERVERCONFFILE has been added for 2 DC testenvs, where we need
the PDC's smb.conf.

The benefit of doing this way is the filepath/testenv-dependency logic
is all self-contained with the Perl code, and it doesn't bleed out into
tests.py as well.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit aeadf75c24a4af4143e389e2b27d3a90899fb638)

Fixes autobuild with the patches for
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14285

Autobuild-User(v4-10-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-10-test): Wed Mar  4 11:26:37 UTC 2020 on sn-devel-144
selftest/selftest.pl
selftest/target/Samba4.pm