]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
coresight: tpda: fix the logic to setup the element size
authorJie Gan <jie.gan@oss.qualcomm.com>
Fri, 5 Sep 2025 23:53:04 +0000 (07:53 +0800)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Tue, 23 Sep 2025 13:14:13 +0000 (14:14 +0100)
commit43e0a92c04de7c822f6104abc73caa4a857b4a02
treed9dff32060e71df9b3c1d4043bc7dc22ca758e57
parent8a55c161f7f9c1aa1c70611b39830d51c83ef36d
coresight: tpda: fix the logic to setup the element size

Some TPDM devices support both CMB and DSB datasets, requiring
the system to enable the port with both corresponding element sizes.

Currently, the logic treats tpdm_read_element_size as successful if
the CMB element size is retrieved correctly, regardless of whether
the DSB element size is obtained. This behavior causes issues
when parsing data from TPDM devices that depend on both element sizes.

To address this, the function should explicitly fail if the DSB
element size cannot be read correctly.

Fixes: e6d7f5252f73 ("coresight-tpda: Add support to configure CMB element")
Reviewed-by: James Clark <james.clark@linaro.org>
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20250906-fix_element_size_issue-v2-1-dbb0ac2541a9@oss.qualcomm.com
drivers/hwtracing/coresight/coresight-tpda.c