]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nfsd: stricter decoding of write-like NFSv2/v3 ops
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 21 Apr 2017 19:26:30 +0000 (15:26 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 May 2017 15:37:43 +0000 (08:37 -0700)
commit43e360377b09107e6c3b278c49f41fcc58802fdd
tree359b45ed13f11fee61448a2ec0068af49ee9dd99
parent144180dc47361c1168b4efce3211696ffd1fe4e4
nfsd: stricter decoding of write-like NFSv2/v3 ops

commit 13bf9fbff0e5e099e2b6f003a0ab8ae145436309 upstream.

The NFSv2/v3 code does not systematically check whether we decode past
the end of the buffer.  This generally appears to be harmless, but there
are a few places where we do arithmetic on the pointers involved and
don't account for the possibility that a length could be negative.  Add
checks to catch these.

Reported-by: Tuomas Haanpää <thaan@synopsys.com>
Reported-by: Ari Kauppi <ari@synopsys.com>
Reviewed-by: NeilBrown <neilb@suse.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfsd/nfs3xdr.c
fs/nfsd/nfsxdr.c