]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/xe/guc: Don't invoke disable_ct action during replacement
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Mon, 8 Sep 2025 10:20:52 +0000 (12:20 +0200)
committerMichal Wajdeczko <michal.wajdeczko@intel.com>
Tue, 9 Sep 2025 18:38:26 +0000 (20:38 +0200)
commit43fac1b2f015daedc6046863f7664f3178f0bbe2
tree30e91666b1a248bab590eab3be424f49b8998679
parent955f3bc4af440bb950c7a1567197aaf6aa2213ae
drm/xe/guc: Don't invoke disable_ct action during replacement

During second CT initialization step, known as post_hwconfig, we
want to replace previously registered CT disable devm action to
make sure it will be invoked prior to releasing underlying BO.

But to replace this action we don't need to execute it right away
since we know that CT was disabled prior to that late init step
and we already assert that. Use devm_remove_action() instead to
avoid extra message about 'disabling CT' that could be seen now:

 [drm:guc_ct_change_state [xe]] GT0: GuC CT communication channel disabled
 ...
 DEVRES REM ff11000149320940 guc_action_disable_ct (16 bytes)
 [drm:guc_ct_change_state [xe]] GT0: GuC CT communication channel disabled
 DEVRES ADD ff110001664fc040 guc_action_disable_ct (16 bytes)

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
Link: https://lore.kernel.org/r/20250908102053.539-3-michal.wajdeczko@intel.com
drivers/gpu/drm/xe/xe_guc_ct.c