]> git.ipfire.org Git - thirdparty/shadow.git/commit
Remove definition of ISDIGIT_LOCALE(c)
authorAlejandro Colomar <alx.manpages@gmail.com>
Tue, 28 Dec 2021 18:38:58 +0000 (19:38 +0100)
committerAlejandro Colomar <alx.manpages@gmail.com>
Wed, 29 Dec 2021 01:41:09 +0000 (02:41 +0100)
commit44126d85ee9a33d10e24da1a8b901f8145918d95
treeb24b0915c01b610f0dbae057771ad8c6314d39e1
parent2a41a72b8cfd05b9d6b050194ea6e1c877b9fd3b
Remove definition of ISDIGIT_LOCALE(c)

It wasn't being used at all.  Let's remove it.

Use isdigit(3) directly in comments that referenced it.

Also, in those comments, remove an outdated reference to the fact
that ISDIGIT_LOCALE(c) might evaluate its argument more than once,
which could be true a few commits ago, until
IN_CTYPE_DEFINITION(c) was removed.  Previously, the definition
for ISDIGIT_LOCALE(c) was:

 #if defined (STDC_HEADERS) || (!defined (isascii) && !defined (HAVE_ISASCII))
 # define IN_CTYPE_DOMAIN(c) 1
 #else
 # define IN_CTYPE_DOMAIN(c) isascii(c)
 #endif

 #define ISDIGIT_LOCALE(c) (IN_CTYPE_DOMAIN (c) && isdigit (c))

Which could evaluate 'c' twice on pre-C89 systems (which I hope
don't exist nowadays).

Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
lib/defines.h
libmisc/getdate.y