]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
btrfs: don't clobber errors in add_remap_tree_entries()
authorMark Harmstone <maharmstone@fb.com>
Mon, 23 Mar 2026 17:17:01 +0000 (17:17 +0000)
committerDavid Sterba <dsterba@suse.com>
Tue, 21 Apr 2026 02:01:43 +0000 (04:01 +0200)
commit44366af74061793ee5ceef455a4f0e465892d0de
treeb58ff7eaa380e6382b40fb5def0184301da40ba9
parent41e706c07ef9f752a08f0b9567176ac79441895f
btrfs: don't clobber errors in add_remap_tree_entries()

In add_remap_tree_entries(), we only process a certain number of entries
at a time, meaning we may need to loop.

But because we weren't checking the return value of btrfs_insert_empty_items()
within the loop, this meant that if the last iteration of the loop
succeeded but a previous iteration failed, we were erroneously returning
0.

Fix this by breaking the loop early if btrfs_insert_empty_items() fails.

Fixes: b56f35560b82 ("btrfs: handle setting up relocation of block group with remap-tree")
Signed-off-by: Mark Harmstone <mark@harmstone.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/relocation.c