]> git.ipfire.org Git - thirdparty/linux.git/commit
nvme-auth: common: explicitly verify psk_len == hash_len
authorEric Biggers <ebiggers@kernel.org>
Mon, 2 Mar 2026 07:59:44 +0000 (23:59 -0800)
committerKeith Busch <kbusch@kernel.org>
Fri, 27 Mar 2026 14:35:00 +0000 (07:35 -0700)
commit4454820b4ee59154d0c271722bbe48bb4f554e3e
tree3e135b00f10b8c1350eac7a54ca777e4728e8c6c
parent0beeca72cf21c7c1d9d232148fdeef8e5e242f62
nvme-auth: common: explicitly verify psk_len == hash_len

nvme_auth_derive_tls_psk() is always called with psk_len == hash_len.
And based on the comments above nvme_auth_generate_psk() and
nvme_auth_derive_tls_psk(), this isn't an implementation choice but
rather just the length the spec uses.  Add a check which makes this
explicit, so that when cleaning up nvme_auth_derive_tls_psk() we don't
have to retain support for arbitrary values of psk_len.

Acked-by: Ard Biesheuvel <ardb@kernel.org>
Acked-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/common/auth.c