]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/tls: don't ignore netdev notifications if no TLS features
authorJakub Kicinski <jakub.kicinski@netronome.com>
Wed, 22 May 2019 02:02:02 +0000 (19:02 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 4 Jun 2019 06:01:30 +0000 (08:01 +0200)
commit446051af00e0bcdf74ab4463ddf5e1b1bf93aa08
tree4fbffc61f9b70edc096f49db2719fd990848dc43
parent3a7c06b38ccfb1776798a77f0c8a2dfd27290fed
net/tls: don't ignore netdev notifications if no TLS features

[ Upstream commit c3f4a6c39cf269a40d45f813c05fa830318ad875 ]

On device surprise removal path (the notifier) we can't
bail just because the features are disabled.  They may
have been enabled during the lifetime of the device.
This bug leads to leaking netdev references and
use-after-frees if there are active connections while
device features are cleared.

Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/tls/tls_device.c