]> git.ipfire.org Git - thirdparty/asterisk.git/commit
app_confbridge: Bridge and announcers not removed if conference ends quickly
authorRobert Mordec <r.mordec@slican.pl>
Mon, 21 May 2018 12:24:51 +0000 (14:24 +0200)
committerRichard Mudgett <rmudgett@digium.com>
Fri, 29 Jun 2018 16:06:26 +0000 (11:06 -0500)
commit447ec4e472591dc6fac313ab2d8636b49fe35406
treed107ee9aa8708b40c64d38e76c0cf9715de15195
parent6b6fa461d659731aa3deea62e2022e6c3965646c
app_confbridge: Bridge and announcers not removed if conference ends quickly

If a conference is ended very quickly after it was created (i.e., the
first user immediately hangs up) then the conference bridge and announcer
channels are not removed.

When a conference is created, the push_announcer() function is added to
the playback queue task processor and the conference object reference is
bumped.  If a conference is ended while the push_announcer() function is
still going then the ao2_cleanup(conference) at the end of
push_announcer() will call the destructor function -
destroy_conference_bridge().

The destroy_conference_bridge() function will then add the
hangup_playback() task to the playback queue and will wait for it to end.
Since it is already a current task of the playback queue it will wait
forever.

This patch makes the conference thread call push_announcer() directly.
This way the conference object reference bump is not needed.  Since the
playback queue task processor is only used by the conference thread
itself, there is no danger of trying to play announcements before the
announcer is pushed to the bridge.

ASTERISK-27870 #close

Change-Id: I947a50fb121422d90fd1816d643a54d75185a477
apps/app_confbridge.c