]> git.ipfire.org Git - thirdparty/git.git/commit
transport: fix leak with transport helper URLs
authorJunio C Hamano <gitster@pobox.com>
Thu, 8 Aug 2024 00:32:56 +0000 (17:32 -0700)
committerJunio C Hamano <gitster@pobox.com>
Thu, 8 Aug 2024 00:38:31 +0000 (17:38 -0700)
commit448d51d549179bafe47e07e9434210d48fdf55c6
treef99347e604815f05ef2640e5c775d8fadb25e47c
parent406f326d271e0bacecdb00425422c5fa3f314930
transport: fix leak with transport helper URLs

Transport URLs can be prefixed with "foo::", which would tell us that
the transport uses a remote helper called "foo". We extract the helper
name by `xstrndup()`ing the prefix before the double-colons, but never
free that string.

Fix this leak by assigning the result to a separate local variable that
we can then free upon returning.

Helped-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
transport.c