]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: make passt+vhostuser reconnect behave identically to passt+user
authorLaine Stump <laine@redhat.com>
Fri, 4 Apr 2025 23:44:52 +0000 (19:44 -0400)
committerLaine Stump <laine@redhat.com>
Fri, 11 Apr 2025 03:48:46 +0000 (23:48 -0400)
commit44abaa0128ac0fc8be9de4eebc15c03809bf5867
tree003b9491e63c11083ca8eb391d819b643397b9b8
parent95ff77f2896478e039673bb552affec2c5a5e822
qemu: make passt+vhostuser reconnect behave identically to passt+user

When "original passt" support was added, we decided that we always
wanted to reconnect (i.e. restart the passt process) if it was somehow
terminated. Generic vhost-user, on the other hand, only turns on
reconnect if specified by the user in the config. But there is no
reason to require the user to specify this if the other end of the
vhost-user socket is a passt process - we know what has happened and
what we want to do; no reason to do the *wrong* thing by default, and
force the user to make an arbitrary decision about what to add to the
config in order to make it do the *right* thing; instead we just
hardcode it to always do the right thing.

(NB: when the backend is passt, <interface type='vhostuser'> has
always ignored the reconnect setting in <source> when parsing and
formatting, just as it has always ignored the socket path (since that
also is not user configurable for the passt backend)

Resolves: https://issues.redhat.com/browse/RHEL-80169

Signed-off-by: Laine Stump <laine@redhat.com>
Tested-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_passt.c
tests/qemuxmlconfdata/net-vhostuser-passt.x86_64-latest.args
tests/qemuxmlconfdata/schema-reorder-domain-subelements.x86_64-latest.args