]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/display/dp_mst: Fix drm_dp_mst_add_affected_dsc_crtcs() return code
authorLyude Paul <lyude@redhat.com>
Mon, 14 Nov 2022 22:17:53 +0000 (17:17 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Dec 2022 10:23:54 +0000 (11:23 +0100)
commit44b204730bf32131f064ebc90145092590c7fe95
treef710615ef951fdce5cc914b81c2599e428a88810
parent1faf21bdd111c0c6e7b4dc6b9fc353870a140a9b
drm/display/dp_mst: Fix drm_dp_mst_add_affected_dsc_crtcs() return code

[ Upstream commit 2f3a1273862cb82cca227630cc7f04ce0c94b6bb ]

Looks like that we're accidentally dropping a pretty important return code
here. For some reason, we just return -EINVAL if we fail to get the MST
topology state. This is wrong: error codes are important and should never
be squashed without being handled, which here seems to have the potential
to cause a deadlock.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Wayne Lin <Wayne.Lin@amd.com>
Fixes: 8ec046716ca8 ("drm/dp_mst: Add helper to trigger modeset on affected DSC MST CRTCs")
Cc: <stable@vger.kernel.org> # v5.6+
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/drm_dp_mst_topology.c