]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
memory: pl353-smc: Fix refcount leak bug in pl353_smc_probe()
authorLiang He <windhl@126.com>
Sat, 16 Jul 2022 03:13:24 +0000 (11:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:57:24 +0000 (09:57 +0200)
commit44db35ceb94756ba513dcf6b69bf9e949b28469c
tree06ff459e9dc2c8b170a1764df97c784e79472ed4
parent7cdc122f28d71a8170be467323eebc5bfef32476
memory: pl353-smc: Fix refcount leak bug in pl353_smc_probe()

[ Upstream commit 61b3c876c1cbdb1efd1f52a1f348580e6e14efb6 ]

The break of for_each_available_child_of_node() needs a
corresponding of_node_put() when the reference 'child' is not
used anymore. Here we do not need to call of_node_put() in
fail path as '!match' means no break.

While the of_platform_device_create() will created a new
reference by 'child' but it has considered the refcounting.

Fixes: fee10bd22678 ("memory: pl353: Add driver for arm pl353 static memory controller")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220716031324.447680-1-windhl@126.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/memory/pl353-smc.c