]> git.ipfire.org Git - thirdparty/glibc.git/commit
x86: Check IFUNC definition in unrelocated executable [BZ #20019]
authorH.J. Lu <hjl.tools@gmail.com>
Mon, 28 Dec 2020 13:28:49 +0000 (05:28 -0800)
committerH.J. Lu <hjl.tools@gmail.com>
Wed, 13 Jan 2021 23:17:05 +0000 (15:17 -0800)
commit44fd8887d0dc705ee5a8e52153282292841e0a01
treeb8bd935001f5a84bd73010b65f0d9d978f1dfed0
parent4a68828e3781cd6f61f792daa1dd5904a8f45288
x86: Check IFUNC definition in unrelocated executable [BZ #20019]

Calling an IFUNC function defined in unrelocated executable also leads to
segfault.  Issue a fatal error message when calling IFUNC function defined
in the unrelocated executable from a shared library.

On x86, ifuncmain6pie failed with:

[hjl@gnu-cfl-2 build-i686-linux]$ ./elf/ifuncmain6pie --direct
./elf/ifuncmain6pie: IFUNC symbol 'foo' referenced in '/export/build/gnu/tools-build/glibc-32bit/build-i686-linux/elf/ifuncmod6.so' is defined in the executable and creates an unsatisfiable circular dependency.
[hjl@gnu-cfl-2 build-i686-linux]$ readelf -rW elf/ifuncmod6.so | grep foo
00003ff4  00000706 R_386_GLOB_DAT         0000400c   foo_ptr
00003ff8  00000406 R_386_GLOB_DAT         00000000   foo
0000400c  00000401 R_386_32               00000000   foo
[hjl@gnu-cfl-2 build-i686-linux]$

Remove non-JUMP_SLOT relocations against foo in ifuncmod6.so, which
trigger the circular IFUNC dependency, and build ifuncmain6pie with
-Wl,-z,lazy.

(cherry picked from commits 6ea5b57afa5cdc9ce367d2b69a2cebfb273e4617
 and 7137d682ebfcb6db5dfc5f39724718699922f06c)
NEWS
elf/Makefile
elf/ifuncmain6pie.c
elf/ifuncmod6.c
sysdeps/i386/dl-machine.h
sysdeps/x86_64/dl-machine.h