]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: renesas: rz-ssi: Add a check for negative sample_space
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 8 Jan 2025 09:28:46 +0000 (12:28 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Feb 2025 12:30:15 +0000 (04:30 -0800)
commit4543b1b8f8655ea17f69cda85910b3fe52427b83
tree5d238b3ec3129a97f0cce784650d7b49023ba98f
parentfffb4a352672082316c5ae80977640aa0a85dfe6
ASoC: renesas: rz-ssi: Add a check for negative sample_space

[ Upstream commit 82a0a3e6f8c02b3236b55e784a083fa4ee07c321 ]

My static checker rule complains about this code.  The concern is that
if "sample_space" is negative then the "sample_space >= runtime->channels"
condition will not work as intended because it will be type promoted to a
high unsigned int value.

strm->fifo_sample_size is SSI_FIFO_DEPTH (32).  The SSIFSR_TDC_MASK is
0x3f.  Without any further context it does seem like a reasonable warning
and it can't hurt to add a check for negatives.

Cc: stable@vger.kernel.org
Fixes: 03e786bd4341 ("ASoC: sh: Add RZ/G2L SSIF-2 driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://patch.msgid.link/e07c3dc5-d885-4b04-a742-71f42243f4fd@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/sh/rz-ssi.c