]> git.ipfire.org Git - thirdparty/curl.git/commit
projects / thirdparty / curl.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: a7bbbb7) | patch
curl: do bounds check using a double comparison
authorAdam Sampson <ats@offog.org>
Wed, 9 Aug 2017 13:11:17 +0000 (14:11 +0100)
committerDaniel Stenberg <daniel@haxx.se>
Wed, 9 Aug 2017 17:24:16 +0000 (19:24 +0200)
commit45a560390c4356bcb81d933bbbb229c8ea2acb63
treef7a2c702f30a69c5dd1b9fd2fe3b427f65104b1etree | snapshot
parenta7bbbb7c368c6096802007f61f19a02e9d75285bcommit | diff
curl: do bounds check using a double comparison

The fix for this in 8661a0aacc01492e0436275ff36a21734f2541bb wasn't
complete: if the parsed number in num is larger than will fit in a long,
the conversion is undefined behaviour (causing test1427 to fail for me
on IA32 with GCC 7.1, although it passes on AMD64 and ARMv7).  Getting
rid of the cast means the comparison will be done using doubles.

It might make more sense for the max argument to also be a double...

Fixes #1750
Closes #1749
src/tool_paramhlp.c diff | blob | blame | history
Mirror of https://github.com/curl/curl.git