]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI: qcom: Restrict port parsing only to PCIe bridge child nodes
authorKrishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Tue, 26 Aug 2025 11:02:55 +0000 (16:32 +0530)
committerManivannan Sadhasivam <mani@kernel.org>
Wed, 27 Aug 2025 14:50:24 +0000 (20:20 +0530)
commit45df22935bdc6bbddf87f38a57ae7257244cf3cf
tree98175d3b0599c8c4738dfd5c47f82d2efd498dbe
parentadd7b05aeeb417c86239e6731a168e6c46b83279
PCI: qcom: Restrict port parsing only to PCIe bridge child nodes

The qcom_pcie_parse_ports() function currently iterates over all available
child nodes of the PCIe controller's device tree node. This includes
unrelated nodes such as OPP (Operating Performance Points) nodes, which do
not contain the expected 'reset' and 'phy' properties. As a result, parsing
fails and the driver falls back to the legacy method of parsing the
controller node directly. However, this fallback also fails when properties
are shifted to the Root Port node, leading to probe failure.

Fix this by restricting the parsing logic to only consider child nodes with
device_type = "pci", which is the expected and required property for PCIe
bridge nodes as per the pci-bus-common.yaml dtschema.

Fixes: a2fbecdbbb9d ("PCI: qcom: Add support for parsing the new Root Port binding")
Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
[mani: reworded subject and description]
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://patch.msgid.link/20250826-pakala-v3-3-721627bd5bb0@oss.qualcomm.com
drivers/pci/controller/dwc/pcie-qcom.c