]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.14] gh-136839: Refactor simple dict.update calls (GH-136811) (#136840)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Sat, 19 Jul 2025 17:36:31 +0000 (19:36 +0200)
committerGitHub <noreply@github.com>
Sat, 19 Jul 2025 17:36:31 +0000 (17:36 +0000)
commit4606b4089d727ea879e6233ec4a366fffcb28fa1
tree789e3ba71a43bbdae3d3176ea6e0e768b92d61ee
parentf8af7cb7231bdb4ae7137c690da4e3903d0ce5f9
[3.14] gh-136839: Refactor simple dict.update calls (GH-136811) (#136840)

gh-136839: Refactor simple dict.update calls (GH-136811)

Refactor simple dict.update calls

This commit refactors simple `dict.update({key: value})` calls which can
be done via `dict[key] = value` instead.

I found those cases with the [semgrep](https://semgrep.dev/) tool:

```
$ semgrep --lang python --pattern '$DICT.update({$A: ...})'

┌─────────────────┐
│ 5 Code Findings │
└─────────────────┘

    Lib/dataclasses.py
         1268┆ slots.update({slot: doc})

    Lib/multiprocessing/resource_tracker.py
           50┆ _CLEANUP_FUNCS.update({
           51┆     'semaphore': _multiprocessing.sem_unlink,
           52┆ })
            ⋮┆----------------------------------------
           53┆ _CLEANUP_FUNCS.update({
           54┆     'shared_memory': _posixshmem.shm_unlink,
           55┆ })

    Lib/tkinter/scrolledtext.py
           26┆ kw.update({'yscrollcommand': self.vbar.set})

    Lib/xmlrpc/server.py
          242┆ self.funcs.update({'system.multicall' : self.system_multicall})
```
(cherry picked from commit 69ea1b3a8f45fec46add3272ad47f14ff5321ae8)

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Lib/dataclasses.py
Lib/multiprocessing/resource_tracker.py
Lib/tkinter/scrolledtext.py
Lib/xmlrpc/server.py